Skip to content

Add conversion into (Option<A>,Option<B>) to EitherOrBoth #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 29, 2023
Merged

Add conversion into (Option<A>,Option<B>) to EitherOrBoth #713

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83f45a3
Add conversion into (Option<A>,Option<B>) to EitherOrBoth
JustusFluegel Jul 13, 2023
ca23089
Change to use From instead of Into
JustusFluegel Jul 13, 2023
d171cee
Add left_or_right() method to EitherOrBoth, delegate From impl to it.
JustusFluegel Jul 15, 2023
44f5f7b
Correct spelling of tuple
JustusFluegel Jul 15, 2023
5fe48e5
Add inline(always)
JustusFluegel Jul 15, 2023
d7a539f
Remove From impl, change left_and_right impl to use .or_default()
JustusFluegel Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/either_or_both.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ impl<A, B> EitherOrBoth<A, B> {
}
}

/// Return tuple of options corresponding to the left and right value respectively
///
/// If `Left` return `(Some(..), None)`, if `Right` return `(None,Some(..))`, else return
/// `(Some(..),Some(..))`
pub fn left_and_right(self) -> (Option<A>, Option<B>) {
self.map_any(Some, Some).or_default()
}

/// If `Left`, return `Some` with the left value. If `Right` or `Both`, return `None`.
///
/// # Examples
Expand Down Expand Up @@ -464,7 +472,7 @@ impl<A, B> EitherOrBoth<A, B> {
impl<T> EitherOrBoth<T, T> {
/// Return either value of left, right, or apply a function `f` to both values if both are present.
/// The input function has to return the same type as both Right and Left carry.
///
///
/// # Examples
/// ```
/// # use itertools::EitherOrBoth;
Expand Down