ConsTuples: remove DoubleEndedIterator implementation
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jswrenn could you merge this (or veto if you think we should fix it)? |
jswrenn
reviewed
Jan 16, 2024
There was a problem hiding this comment.
I think we should consider the removal of a trait impl to be a breaking change, even if it's the case that that impl did not behave correctly. There may be consumers who are happy with the buggy behavior, and who would be severely inconvenienced if they could no longer satisfy a DoubleEndedIterator trait bound in generic code.
Let's merge this at the same time as #835.
Merged
jswrenn
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #852
Breaking change or simple bugfix?