-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated #878
Remove deprecated #878
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
+ Coverage 94.38% 94.53% +0.15%
==========================================
Files 48 48
Lines 6665 6574 -91
==========================================
- Hits 6291 6215 -76
+ Misses 374 359 -15 ☔ View full report in Codecov by Sentry. |
The list of deprecations is not complete. I used some command line to make the list but it clearly did not do what I expected. EDIT: It was only missing At first, I did not understand why semver-checks passed CI but it's simply because the version was bumped in |
b2ea41a
to
1dc7bce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
c68e6b4
At the same time as #877, I listed our deprecated parts:
Itertools::group_by
since 0.13.0
Itertools::chunk_by
Do not remove!
unfold
since 0.13.0
core::iter::from_fn
MSRV ≥ 1.34.0
Do not remove!
Itertools::fold1
since 0.10.2
Iterator::reduce
MSRV ≥ 1.51.0
since MSRV = 1.43.1
Do not remove!
zip
since 0.10.4
core::iter::zip
MSRV ≥ 1.59.0
since MSRV = 1.43.1
Do not remove!
repeat_call
since 0.8.0
core::iter::repeat_with
MSRV ≥ 1.28.0
Itertools::foreach
since 0.8.0
Iterator::for_each
MSRV ≥ 1.21.0
Itertools::step
since 0.8.0
Iterator::step_by
MSRV ≥ 1.28.0
Itertools::map_results
since 0.10.0
Itertools::map_ok
Itertools::fold_results
since 0.10.0
Itertools::fold_ok
Should we remove
repeat_call, Itertools::{foreach, step, map_results, fold_results}
(which is what I did here)?Or when should we?
Note: 0.8.0 and 0.10.0 are resp. 5 and 3 years old.