Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated #878

Merged

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Feb 13, 2024

At the same time as #877, I listed our deprecated parts:

Deprecated Alternative Comment
Itertools::group_by
since 0.13.0
Itertools::chunk_by Newly deprecated.
Do not remove!
unfold
since 0.13.0
core::iter::from_fn
MSRV ≥ 1.34.0
Newly deprecated.
Do not remove!
Itertools::fold1
since 0.10.2
Iterator::reduce
MSRV ≥ 1.51.0
Unavailable alternative
since MSRV = 1.43.1
Do not remove!
zip
since 0.10.4
core::iter::zip
MSRV ≥ 1.59.0
Unavailable alternative
since MSRV = 1.43.1
Do not remove!
repeat_call
since 0.8.0
core::iter::repeat_with
MSRV ≥ 1.28.0
Remove?!
Itertools::foreach
since 0.8.0
Iterator::for_each
MSRV ≥ 1.21.0
Remove?!
Itertools::step
since 0.8.0
Iterator::step_by
MSRV ≥ 1.28.0
Remove?!
Itertools::map_results
since 0.10.0
Itertools::map_ok Remove?!
Itertools::fold_results
since 0.10.0
Itertools::fold_ok Remove?!

Should we remove repeat_call, Itertools::{foreach, step, map_results, fold_results} (which is what I did here)?
Or when should we?

Note: 0.8.0 and 0.10.0 are resp. 5 and 3 years old.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6814180) 94.38% compared to head (1dc7bce) 94.53%.
Report is 10 commits behind head on master.

Files Patch % Lines
src/sources.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   94.38%   94.53%   +0.15%     
==========================================
  Files          48       48              
  Lines        6665     6574      -91     
==========================================
- Hits         6291     6215      -76     
+ Misses        374      359      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet marked this pull request as draft February 13, 2024 13:25
@Philippe-Cholet
Copy link
Member Author

Philippe-Cholet commented Feb 13, 2024

The list of deprecations is not complete. I used some command line to make the list but it clearly did not do what I expected.

EDIT: It was only missing zip, list updated.

At first, I did not understand why semver-checks passed CI but it's simply because the version was bumped in Cargo.toml to 0.13.0. 🙄

Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

src/adaptors/mod.rs Show resolved Hide resolved
src/adaptors/mod.rs Show resolved Hide resolved
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Feb 19, 2024
@Philippe-Cholet Philippe-Cholet added this to the next milestone Feb 19, 2024
Merged via the queue into rust-itertools:master with commit c68e6b4 Feb 19, 2024
12 of 13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the remove-deprecated branch February 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants