Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GroupingMap::fold_first for reduce #902

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Mar 14, 2024

I just became aware of rust-lang/rust#68125 and rust-lang/rust#79805 and the names that were previously considered.

So we have:

What a naming mess!

Hopefully, we might be able to remove all three deprecated methods at the same time and close this page once and for all.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.16%. Comparing base (6814180) to head (714ca2e).
Report is 31 commits behind head on master.

Files Patch % Lines
src/grouping_map.rs 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   94.38%   94.16%   -0.23%     
==========================================
  Files          48       48              
  Lines        6665     6755      +90     
==========================================
+ Hits         6291     6361      +70     
- Misses        374      394      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Mar 14, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Mar 14, 2024
Merged via the queue into rust-itertools:master with commit 6a69bd9 Mar 14, 2024
12 of 13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the deprecate-groupingmap-fold_first branch March 14, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants