Deprecate GroupingMap::fold_first
for reduce
#902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just became aware of rust-lang/rust#68125 and rust-lang/rust#79805 and the names that were previously considered.
So we have:
Itertools::fold1
(deprecated) which basically isIterator::reduce
.Itertools::tree_fold1
deprecated/renamedtree_reduce
in Deprecatetree_fold1
fortree_reduce
#895 (not merged yet).GroupingMap::fold_first
and rename itreduce
(before I finish More generic maps (inGroupingMap
) #901 where I might have wrote a newfold_first_in
instead ofreduce_in
).What a naming mess!
Hopefully, we might be able to remove all three deprecated methods at the same time and close this page once and for all.