Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent exponentially large type sizes in tuple_combinations #945

Merged
merged 1 commit into from
May 24, 2024
Merged

Prevent exponentially large type sizes in tuple_combinations #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/adaptors/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,16 +773,28 @@ macro_rules! impl_tuple_combination {
where
F: FnMut(B, Self::Item) -> B,
{
// We outline this closure to prevent it from unnecessarily
// capturing the type parameters `I`, `B`, and `F`. Not doing
// so ended up causing exponentially big types during MIR
// inlining when building itertools with optimizations enabled.
//
// This change causes a small improvement to compile times in
// release mode.
type CurrTuple<A> = (A, $(ignore_ident!($X, A)),*);
type PrevTuple<A> = ($(ignore_ident!($X, A),)*);
fn map_fn<A: Clone>(z: &A) -> impl FnMut(PrevTuple<A>) -> CurrTuple<A> + '_ {
move |($($X,)*)| (z.clone(), $($X),*)
}
let Self { c, item, mut iter } = self;
if let Some(z) = item.as_ref() {
init = c
.map(|($($X,)*)| (z.clone(), $($X),*))
.map(map_fn::<A>(z))
.fold(init, &mut f);
}
while let Some(z) = iter.next() {
let c: $P<I> = iter.clone().into();
init = c
.map(|($($X,)*)| (z.clone(), $($X),*))
.map(map_fn::<A>(&z))
.fold(init, &mut f);
}
init
Expand Down