Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase discoverability of merge_join_by (Unix-like comm) #966

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Philippe-Cholet
Copy link
Member

Fixes #963

I suggest we follow the same policy as the stdlib: https://std-dev-guide.rust-lang.org/policy/doc-alias.html
And I agree with @VorpalBlade that comm is a fitting alias.

PS: Doc aliases requires rust 1.48 so we are good now.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (6814180) to head (84ce7cc).
Report is 111 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   94.38%   94.64%   +0.25%     
==========================================
  Files          48       49       +1     
  Lines        6665     7229     +564     
==========================================
+ Hits         6291     6842     +551     
- Misses        374      387      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@phimuemue phimuemue added this pull request to the merge queue Sep 18, 2024
Merged via the queue into rust-itertools:master with commit a31e14f Sep 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comm iterator (inspired by Unix comm command)?
2 participants