Auto merge of rust-lang#84174 - camsteffen:slice-diag, r=Mark-Simulacrum

bors · bors · commit ae54ee650750 · 2021-04-26T17:16:03.000Z
Remove slice diagnostic item ...because it is unusally placed on an impl and is redundant with a lang item. Depends on rust-lang/rust-clippy#7074 (next clippy sync). ~I expect clippy tests to fail in the meantime.~ Nope tests passed... CC `@flip1995`
diff --git a/library/alloc/src/slice.rs b/library/alloc/src/slice.rs
@@ -222,7 +222,6 @@ mod hack {
 }
 
 #[lang = "slice_alloc"]
-#[cfg_attr(not(test), rustc_diagnostic_item = "slice")]
 #[cfg(not(test))]
 impl<T> [T] {
     /// Sorts the slice.

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,6 @@ mod hack {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`#[lang = "slice_alloc"]`
`225`		`-#[cfg_attr(not(test), rustc_diagnostic_item = "slice")]`
`226`	`225`	`#[cfg(not(test))]`
`227`	`226`	`impl<T> [T] {`
`228`	`227`	`/// Sorts the slice.`