Remove slice diagnostic item #84174
Merged
Remove slice diagnostic item #84174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I think clippy tests don't run for PRs, so this may still be needed until the submodule sync. |
|
Clippy tests only run on a PR, if something in the Clippy dir was changed. You'll have to check this locally: |
|
FWIW using the diagnostic item feels reasonable for diagnostic purposes (rather than using the lang item). But no big deal either way. r=me once we clippy sync |
|
Sync PR is up: #84427 |
|
Sync is merged. A local clippy test passed. @bors r=Mark-Simulacrum |
|
📌 Commit b319031 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because it is unusally placed on an impl and is redundant with a lang item.
Depends on rust-lang/rust-clippy#7074 (next clippy sync).
I expect clippy tests to fail in the meantime.Nope tests passed...CC @flip1995