forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of rust-lang#128186 - matthiaskrgr:rollup-01b7t98, r=matth…
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121364 (Implement lint against ambiguous negative literals) - rust-lang#127300 (Fix connect timeout for non-linux targets, read readiness of socket connection, Read readiness to detect errors. `Fixes rust-lang#127018`) - rust-lang#128138 (`#[naked]`: use an allowlist for allowed options on `asm!` in naked functions) - rust-lang#128158 (std: unsafe-wrap personality::gcc) - rust-lang#128171 (Make sure that args are compatible in `resolve_associated_item`) - rust-lang#128172 (Don't ICE if HIR and middle types disagree in borrowck error reporting) - rust-lang#128173 (Remove crashes for misuses of intrinsics) r? `@ghost` `@rustbot` modify labels: rollup
- Loading branch information
Showing
38 changed files
with
762 additions
and
576 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
use rustc_ast::token::LitKind; | ||
use rustc_ast::{Expr, ExprKind, MethodCall, UnOp}; | ||
use rustc_session::{declare_lint, declare_lint_pass}; | ||
|
||
use crate::lints::{ | ||
AmbiguousNegativeLiteralsCurrentBehaviorSuggestion, AmbiguousNegativeLiteralsDiag, | ||
AmbiguousNegativeLiteralsNegativeLiteralSuggestion, | ||
}; | ||
use crate::{EarlyContext, EarlyLintPass, LintContext}; | ||
|
||
declare_lint! { | ||
/// The `ambiguous_negative_literals` lint checks for cases that are | ||
/// confusing between a negative literal and a negation that's not part | ||
/// of the literal. | ||
/// | ||
/// ### Example | ||
/// | ||
/// ```rust,compile_fail | ||
/// # #![allow(unused)] | ||
/// -1i32.abs(); // equals -1, while `(-1i32).abs()` equals 1 | ||
/// ``` | ||
/// | ||
/// {{produces}} | ||
/// | ||
/// ### Explanation | ||
/// | ||
/// Method calls take precedence over unary precedence. Setting the | ||
/// precedence explicitly makes the code clearer and avoid potential bugs. | ||
pub AMBIGUOUS_NEGATIVE_LITERALS, | ||
Deny, | ||
"ambiguous negative literals operations", | ||
report_in_external_macro | ||
} | ||
|
||
declare_lint_pass!(Precedence => [AMBIGUOUS_NEGATIVE_LITERALS]); | ||
|
||
impl EarlyLintPass for Precedence { | ||
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) { | ||
let ExprKind::Unary(UnOp::Neg, operand) = &expr.kind else { | ||
return; | ||
}; | ||
|
||
let mut arg = operand; | ||
let mut at_least_one = false; | ||
while let ExprKind::MethodCall(box MethodCall { receiver, .. }) = &arg.kind { | ||
at_least_one = true; | ||
arg = receiver; | ||
} | ||
|
||
if at_least_one | ||
&& let ExprKind::Lit(lit) = &arg.kind | ||
&& let LitKind::Integer | LitKind::Float = &lit.kind | ||
{ | ||
cx.emit_span_lint( | ||
AMBIGUOUS_NEGATIVE_LITERALS, | ||
expr.span, | ||
AmbiguousNegativeLiteralsDiag { | ||
negative_literal: AmbiguousNegativeLiteralsNegativeLiteralSuggestion { | ||
start_span: expr.span.shrink_to_lo(), | ||
end_span: arg.span.shrink_to_hi(), | ||
}, | ||
current_behavior: AmbiguousNegativeLiteralsCurrentBehaviorSuggestion { | ||
start_span: operand.span.shrink_to_lo(), | ||
end_span: operand.span.shrink_to_hi(), | ||
}, | ||
}, | ||
); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.