Skip to content
This repository was archived by the owner on Aug 16, 2021. It is now read-only.

Fix rustc build #199

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Fix rustc build #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107c47d
Fix rustc build
GuillaumeGomez Jul 27, 2017
00dfe9b
Update changelog
GuillaumeGomez Jul 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- [Add a new method for `Error`: `chain_err`.](https://github.com/brson/error-chain/pull/141)
- [Allow `chain_err` to be used on `Option<T>`](https://github.com/brson/error-chain/pull/156)
- [Add support for creating an error chain on boxed trait errors (`Box<Error>`)](https://github.com/brson/error-chain/pull/156)
- [Remove lint for unused doc comment.](https://github.com/brson/error-chain/pull/199)

# 0.10.0

Expand Down
2 changes: 2 additions & 0 deletions src/error_chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ macro_rules! error_chain_processed {
self.0.description()
}

#[allow(unused_doc_comment)]
fn cause(&self) -> Option<&::std::error::Error> {
match self.1.next_error {
Some(ref c) => Some(&**c),
Expand Down Expand Up @@ -423,6 +424,7 @@ macro_rules! impl_extract_backtrace {
($error_name: ident
$error_kind_name: ident
$([$link_error_path: path, $(#[$meta_links: meta])*])*) => {
#[allow(unused_doc_comment)]
fn extract_backtrace(e: &(::std::error::Error + Send + 'static))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, do you know why this one is needed? This item doesn't have a doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it can because of its meta and then we'll have the issue.

-> Option<::std::sync::Arc<$crate::Backtrace>> {
if let Some(e) = e.downcast_ref::<$error_name>() {
Expand Down
4 changes: 2 additions & 2 deletions src/quick_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ macro_rules! quick_error {
$item:ident: $imode:tt [$(#[$imeta:meta])*] [$( $var:ident: $typ:ty ),*] {$( $funcs:tt )*}
)*}
) => {
#[allow(unused)]
#[allow(unused, unused_doc_comment)]
impl ::std::fmt::Display for $name {
fn fmt(&self, fmt: &mut ::std::fmt::Formatter)
-> ::std::fmt::Result
Expand Down Expand Up @@ -310,7 +310,7 @@ macro_rules! quick_error {
}
}
}*/
#[allow(unused)]
#[allow(unused, unused_doc_comment)]
impl $name {
/// A string describing the error kind.
pub fn description(&self) -> &str {
Expand Down