Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Non-privileged users can't cancel non-dist builds #5

Closed
brson opened this issue Jan 28, 2015 · 2 comments
Closed

Non-privileged users can't cancel non-dist builds #5

brson opened this issue Jan 28, 2015 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 28, 2015

We recently added a privileged user for building 'dist' builds. After that patch though non-privileged users can no longer cancel non-dist builds.

cc @bheesham @alexcrichton

@bheesham
Copy link
Contributor

Ah, I think I know what's up here.

On line 1619 of master.cfg, stopBuild provides a BuildStatus object and not a BuilderStatus, which is what the userAuth callback expects. So it's probably running into an AttributeError?

Calling the getBuilder() function on the object should give us what we're looking for.

@alexcrichton
Copy link
Contributor

non-dist builds are no longer a thing, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants