Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Add rust-analysis manifest #150

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Jan 25, 2017

r? @brson

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Contributor

I think we'll also want to add this to the optional components (extensions) array of the rust package. Or at least I think that rustup interprets that?

@nrc
Copy link
Contributor Author

nrc commented Jan 26, 2017

@alexcrichton @brson added to extensions

@brson
Copy link
Contributor

brson commented Jan 30, 2017

@bors r+

@alexcrichton alexcrichton merged commit aefec69 into rust-lang-deprecated:master Feb 1, 2017
@Arnavion
Copy link
Contributor

Arnavion commented Feb 3, 2017

I see this is in 2017-02-03's nightly's manifest, but all the rust-analysis entries are associated with target = "x86_64-unknown-netbsd"

Edit: Seems like it should've been inside a for target in target_list: loop?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants