Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement convolution #45

Merged
merged 6 commits into from
Sep 17, 2020
Merged

Implement convolution #45

merged 6 commits into from
Sep 17, 2020
+503 −4

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 12, 2020

Resolves #38.

@qryxip
Copy link
Member Author

qryxip commented Sep 12, 2020

Finished?

BTW, why not add examples for Library-Cheker? As I said in the Slack before, verification for Library-Checker problems can be done automatically on the CI easily.

https://judge.yosupo.jp/submission/22484

@qryxip qryxip marked this pull request as ready for review September 12, 2020 08:55
@qryxip
Copy link
Member Author

qryxip commented Sep 12, 2020

atcoder/ac-library#30

@qryxip
Copy link
Member Author

qryxip commented Sep 13, 2020

oh no I didn't implement convolution<mod, T>

@qryxip qryxip requested a review from koba-e964 September 14, 2020 08:50
matsu7874
matsu7874 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@matsu7874 matsu7874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qryxip qryxip removed the request for review from koba-e964 September 17, 2020 16:17
@qryxip qryxip merged commit 319d19b into rust-lang-ja:master Sep 17, 2020
@qryxip qryxip deleted the convolution branch September 17, 2020 16:18
@qryxip qryxip mentioned this pull request Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsu7874 matsu7874

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement convolution
2 participants
@qryxip @matsu7874