Remove unnecessary visibilities #55
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
remove-unnecessary-vis
branch
3 times, most recently
from
e573de9 to
f46751d
Compare
qryxip
force-pushed
the
remove-unnecessary-vis
branch
from
f46751d to
f2d8733
Compare
matsu7874
reviewed
Oct 2, 2020
| @@ -11,11 +11,11 @@ pub mod segtree; | |||
| pub mod string; | |||
| pub mod twosat; | |||
|
|
|||
| pub(crate) mod internal_bit; | |||
There was a problem hiding this comment.
Q. Why Is this pub(crate) in lib.rs is unnecessary? Because It is in lib.rs(root of crate)?
There was a problem hiding this comment.
Yes. In the crate root, pub(crate) is equivalent to pub(self), and
pub(self) itemis the same as if one had written justitem.
How is pub(self) visibility different from no pub attribute? - Stack Overflow
But it may be a matter of preference.
qryxip
force-pushed
the
remove-unnecessary-vis
branch
from
f2d8733 to
47a5fbc
Compare
qryxip
force-pushed
the
remove-unnecessary-vis
branch
from
47a5fbc to
69dfa43
Compare
qryxip
force-pushed
the
remove-unnecessary-vis
branch
from
69dfa43 to
e8ecc80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.