Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to reqwest 0.9 #460

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Upgrade to reqwest 0.9 #460

merged 1 commit into from
Oct 2, 2018

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Oct 2, 2018 •
edited
Loading

fixes #459

For some reason, AppVeyor was still running the tests disabled in #430. I tried to ignore them.

Things to check before submitting a PR

  • the tests are passing locally with cargo test
  • cookbook renders correctly in mdbook serve -o
  • commits are squashed into one and rebased to latest master
  • PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge
  • spell check runs without errors ./ci/spellchecker.sh
  • link check runs without errors link-checker ./book
  • non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
  • links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
  • example has standard error handling
  • code identifiers in description are in hyperlinked backticks

Things to do after submitting PR

  • check if CI is happy with your PR

@lnicola lnicola force-pushed the reqwest-0.9 branch 2 times, most recently from 28379a3 to 9db53b3 Compare October 2, 2018 06:51
AndyGauge
AndyGauge reviewed Oct 2, 2018
View reviewed changes
AndyGauge
AndyGauge requested changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@AndyGauge AndyGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some sold work, and I just had a few housekeeping concerns that might as well address before merging, if you don't mind.

@lnicola
Copy link
Contributor Author

lnicola commented Oct 2, 2018

Added a new commit with some phrasing changes. I'll squash after you review it.

@lnicola lnicola mentioned this pull request Oct 2, 2018
Merged
11 tasks
@lnicola
Copy link
Contributor Author

lnicola commented Oct 2, 2018

Rebased and squashed.

@AndyGauge AndyGauge merged commit 2b29e72 into rust-lang-nursery:master Oct 2, 2018
@lnicola lnicola mentioned this pull request Oct 3, 2018
Closed
@lnicola lnicola deleted the reqwest-0.9 branch October 3, 2018 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyGauge AndyGauge AndyGauge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump reqwest to 0.9
2 participants
@lnicola @AndyGauge