Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge yet] Rename rustc-guide to rustc-dev-guide #4

Merged

Conversation

LeSeulArtichaut
Copy link
Contributor

@pietroalbini
Copy link
Contributor

Ping me again when you need this to be merged.

Copy link

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need the URL updated here when you have a chance @LeSeulArtichaut. Thanks!

@LeSeulArtichaut LeSeulArtichaut marked this pull request as ready for review March 9, 2020 22:06
Copy link

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... actually, I think we want the old file name with the redirect URL updated.

@LeSeulArtichaut
Copy link
Contributor Author

Err... you're right 😅

@LeSeulArtichaut
Copy link
Contributor Author

Should be good to go now...

Copy link

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Ping @pietroalbini

@chrissimpkins
Copy link

apologies!

@pietroalbini pietroalbini merged commit 7949831 into rust-lang-nursery:master Mar 10, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the rustc-dev-guide branch March 10, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants