-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rustc-dev-guide
entry
#16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the rustc-guide
entry until rust-lang/rust#69898 is merged (i.e. there should be both rustc-guide
and rustc-dev-guide
entries at the moment).
It is fine as long the latest.json
is a superset of the result recorded in the history/*.tsv
files.
Rest LGTM.
@JohnTitor Ping from triaging. could you address the comments above? Thanks. |
@crlf0710 Hm, transition is going on? |
Seems rust-lang/rust#69898 is blocked on this. So maybe |
@crlf0710 This PR and that rust-lang/rust PR are the remaining things of renaming rustc-guide to rustc-dev-guide (see tracking issue: rust-lang/rustc-dev-guide#602) and currently we're blocked since the transition should be done at once (also it'll affect other PRs on rust-lang/rust iirc so we should do carefully). I'll update this PR once we (wg-learning and infra folks) are ready but I think now is not the time. See the tracking issue or Zulip stream of wg-learning. |
@JohnTitor I think you should address @kennytm comments in order to proceed with both things. So we could first merge this one, then merge the one from rust repo and then we can provide a new PR here to remove |
Heh, I missed that, will follow-up later. |
8f76dad
to
eacab35
Compare
Okay, added |
Yay! Our toolstate will work again 🎉 |
I (think) I'm hitting this at rust-lang/rust#70149 (comment) with Could you please take a look and help me unblock the work on this? EDIT: Error inline:
|
No description provided.