Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc-dev-guide entry #16

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

JohnTitor
Copy link
Member

No description provided.

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the rustc-guide entry until rust-lang/rust#69898 is merged (i.e. there should be both rustc-guide and rustc-dev-guide entries at the moment).

It is fine as long the latest.json is a superset of the result recorded in the history/*.tsv files.

Rest LGTM.

@crlf0710
Copy link
Contributor

crlf0710 commented Apr 3, 2020

@JohnTitor Ping from triaging. could you address the comments above? Thanks.

@JohnTitor
Copy link
Member Author

@crlf0710 Hm, transition is going on?

@crlf0710
Copy link
Contributor

crlf0710 commented Apr 3, 2020

Seems rust-lang/rust#69898 is blocked on this. So maybe rustc-dev-guide item needs to be added first, then remove rustc-guide item in next PR after rust-lang/rust#69898 is merged ? Not sure if i understood it correctly. @JohnTitor

@JohnTitor
Copy link
Member Author

@crlf0710 This PR and that rust-lang/rust PR are the remaining things of renaming rustc-guide to rustc-dev-guide (see tracking issue: rust-lang/rustc-dev-guide#602) and currently we're blocked since the transition should be done at once (also it'll affect other PRs on rust-lang/rust iirc so we should do carefully). I'll update this PR once we (wg-learning and infra folks) are ready but I think now is not the time. See the tracking issue or Zulip stream of wg-learning.

@spastorino
Copy link
Member

spastorino commented Apr 3, 2020

Please keep the rustc-guide entry until rust-lang/rust#69898 is merged (i.e. there should be both rustc-guide and rustc-dev-guide entries at the moment).

It is fine as long the latest.json is a superset of the result recorded in the history/*.tsv files.

Rest LGTM.

@JohnTitor I think you should address @kennytm comments in order to proceed with both things. So we could first merge this one, then merge the one from rust repo and then we can provide a new PR here to remove rustc-guide from that list.

@JohnTitor
Copy link
Member Author

Heh, I missed that, will follow-up later.

@JohnTitor JohnTitor force-pushed the JohnTitor-patch-1 branch from 8f76dad to eacab35 Compare April 4, 2020 16:30
@JohnTitor JohnTitor changed the title Rename to rustc-dev-guide Add rustc-dev-guide entry Apr 4, 2020
@JohnTitor
Copy link
Member Author

Okay, added rustc-dev-guide entry.

@kennytm kennytm merged commit ea1ee26 into rust-lang-nursery:master Apr 4, 2020
@JohnTitor JohnTitor deleted the JohnTitor-patch-1 branch April 4, 2020 16:53
@mark-i-m
Copy link
Contributor

mark-i-m commented Apr 4, 2020

Yay! Our toolstate will work again 🎉

@Xanewok
Copy link

Xanewok commented Apr 4, 2020

I (think) I'm hitting this at rust-lang/rust#70149 (comment) with mingw-check when trying to upgrade RLS and Rustfmt.

Could you please take a look and help me unblock the work on this?

EDIT: Error inline:

tidy check
* 594 error codes
* highest error code: E0751
* 283 features
Checking which error codes lack tests...
Found 491 error codes
Found 0 error codes with no tests
Done!
fmt check
skip untracked path cpu-usage.csv during rustfmt invocations
skip untracked path src/doc/book/ during rustfmt invocations
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
[TIMING] Tidy -- 16.389
Build completed successfully in 0:00:40
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
Traceback (most recent call last):
  File "../../src/tools/publish_toolstate.py", line 305, in <module>
    cur_datetime
  File "../../src/tools/publish_toolstate.py", line 205, in update_latest
    maintainers = ' '.join('@'+name for name in MAINTAINERS[tool])
KeyError: u'rustc-dev-guide'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants