Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Move config files to avoid cluttering project root #207

Merged
merged 6 commits into from
Dec 2, 2021

Conversation

Green-Avocado
Copy link
Contributor

Thanks for your help with the addition of the config file. I based it off how the rls.toml file used to work, where the file was found in the root directory of the project. However, I think it would be better to store config files in a hidden directory, similar to how VSCode does.

Copy link
Contributor

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default path supported by rust-analyzer?

@Green-Avocado
Copy link
Contributor Author

What is the default path supported by rust-analyzer?

As far as I know, rust-analyzer does not have a default path as it requires the client to send it the config.

@aminya
Copy link
Contributor

aminya commented Dec 2, 2021

What is the default path supported by rust-analyzer?

As far as I know, rust-analyzer does not have a default path as it requires the client to send it the config.

I think the current location is reasonable. If we want to avoid cluttering the project root, then it should go to the .config folder or something so different tools can put their config there.

@Green-Avocado
Copy link
Contributor Author

Good idea yeah, I changed the location back to ./rust-analyzer.json and added a check for .config/rust-analyzer.json if the former doesn't exist.

@Green-Avocado Green-Avocado requested a review from aminya December 2, 2021 05:24
@Green-Avocado Green-Avocado requested a review from aminya December 2, 2021 05:36
@aminya aminya merged commit 7e8c377 into rust-lang:master Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants