Pair SymCleanup with calls to SymInitializeW #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will rely on external synchronization but we'll still keep an internal counter to make sure we don't initialize more than once. Performance optimizations for `Backtrace` will come in a later commit. Additionally don't succeed initialization if `SymInitializeW` failed for now, but we can catch it later if necessary in the future.
This commit amortizes the cost of `Backtrace` on Windows by quite a bit by ensuring that `SymInitializeW` is only called once when `Backtrace` is used rather than lots of times recursively. This is purely a performance optimization, however, and shouldn't affect correctness of other users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #165 by ensuring that we call
SymCleanupon Windows. This additionally attempts to mitigate the accompanying performance loss by ensuring that we initialize/cleanup less often when called within scopes of this library. This is extracted from #172 with some cleanup/refactoring.