WIP: Switch from goblin to object
#315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
switch-to-object
branch
from
9e16e5d to
294be70
Compare
alexcrichton
force-pushed
the
switch-to-object
branch
from
294be70 to
7461f81
Compare
|
I should also note that this depends on gimli-rs/object#216 |
|
Done in #317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR using @philipc's work to switch the
goblindependency of thegimli-symbolizefeature to theobjectcrate instead. I explained some rationale for this here but the general idea is that we want a lightweight dependency for parsing object files andgoblinis a bit heavyweight with its custom derive.I mostly just wanted to open this up early-ish to verify it works across all platforms.