Enable Mach-O on iOS in gimli. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think watchos and all other operating systems of apple should be included too. |
|
Fixed! But I am assuming the target_os will be called |
|
Thanks! |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 25, 2020
Bump backtrace-rs to enable Mach-O support on iOS. Related to rust-lang/backtrace-rs#378. Fixes backtraces on iOS that were missing in Rust v1.47.0 after switching to gimli because it only enabled Mach-O support on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for iOS rust-lang/rust#78184.
iOS uses the same Mach-O format as macOS does. I have confirmed that this fix works on
x86_64-apple-ios(tier 2). I expect it will also work onaarch64-apple-ios(tier 2),armv7-apple-ios,armv7s-apple-ios,i386-apple-ios,x86_64-apple-ios-macabi(tier 3), but I don't have the hardware to test on all of those archs.Tier 2:
x86_64-apple-ioscompiles and worksaarch64-apple-ioscompilesTier 3:
armv7-apple-iosarmv7s-apple-iosi386-apple-iosx86_64-apple-ios-macabiaarch64-apple-tvosx86_64-apple-tvosNightly?:
armv7k-apple-watchosi386-apple-watchosx86_64-apple-watchos(Thanks @bjorn3!)