Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enum print::PrintFmt non-exhaustive #651

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Aug 3, 2024

Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@workingjubilee workingjubilee merged commit 95c3bac into rust-lang:master Aug 24, 2024
41 checks passed
@nyurik nyurik deleted the non-exh-enum branch August 24, 2024 21:50
xTVaser pushed a commit to open-goal/launcher that referenced this pull request Sep 10, 2024
…#557)

Bumps the backend-deps group in /src-tauri with 3 updates:
[backtrace](https://github.com/rust-lang/backtrace-rs),
[serde](https://github.com/serde-rs/serde) and
[serde_json](https://github.com/serde-rs/json).

Updates `backtrace` from 0.3.73 to 0.3.74
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/rust-lang/backtrace-rs/releases">backtrace's
releases</a>.</em></p>
<blockquote>
<h2>0.3.74</h2>
<h2>What's Changed</h2>
<ul>
<li>QNX Neutrino 7.0 support, thanks to <a
href="https://github.com/nyurik"><code>@​nyurik</code></a> in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/648">rust-lang/backtrace-rs#648</a></li>
<li>Cleaned up our Android support. This should massively improve
backtraces for ones with the API level sufficient to ship with
libunwind, etc. Unfortunately, it comes at the cost of dropping support
for older ones! Thanks to <a
href="https://github.com/fengys"><code>@​fengys</code></a> in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/656">rust-lang/backtrace-rs#656</a></li>
<li>Made PrintFmt, which was using the
<code>Enum::__NonExhaustiveVariant</code> pattern, use
<code>#[non_exhaustive]</code> for real. Don't @ me if you were matching
on that! Thanks to <a
href="https://github.com/nyurik"><code>@​nyurik</code></a> in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/651">rust-lang/backtrace-rs#651</a></li>
<li>Massively cleaned up the windows code! We moved from winapi to
windows-sys with windows-targets thanks to <a
href="https://github.com/CraftSpider"><code>@​CraftSpider</code></a> and
<a href="https://github.com/ChrisDenton"><code>@​ChrisDenton</code></a>
in
<ul>
<li>Don't cast HANDLE to usize and back by <a
href="https://github.com/CraftSpider"><code>@​CraftSpider</code></a> in
<a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/635">rust-lang/backtrace-rs#635</a></li>
<li>Switch from <code>winapi</code> to <code>windows-sys</code> by <a
href="https://github.com/CraftSpider"><code>@​CraftSpider</code></a> in
<a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/641">rust-lang/backtrace-rs#641</a></li>
<li>Update windows bindings and use windows-targets by <a
href="https://github.com/ChrisDenton"><code>@​ChrisDenton</code></a> in
<a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/653">rust-lang/backtrace-rs#653</a></li>
</ul>
</li>
<li>A bunch of updated dependencies. Thanks <a
href="https://github.com/djc"><code>@​djc</code></a> and <a
href="https://github.com/khuey"><code>@​khuey</code></a>!</li>
<li>Sorry if you were testing this code in miri! It started yelling
about sussy casts. A lot. We did a bunch of internal cleanups that
should make it quiet down, thanks to <a
href="https://github.com/workingjubilee"><code>@​workingjubilee</code></a>
in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/641">rust-lang/backtrace-rs#641</a></li>
<li>Uhhh we had to tweak <code>dl_iterate_phdr</code> in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/660">rust-lang/backtrace-rs#660</a>
after Android revealed it was... kind of unsound actually and not doing
things like checking for null pointers before making slices! WHOOPS!
Thanks to <a
href="https://github.com/saethlin"><code>@​saethlin</code></a> for
implementing detection for precisely that in rustc! It's really hard to
find soundness issues in inherited codebases like this one...</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/CraftSpider"><code>@​CraftSpider</code></a>
made their first contribution in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/635">rust-lang/backtrace-rs#635</a></li>
<li><a
href="https://github.com/fengys1996"><code>@​fengys1996</code></a> made
their first contribution in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/656">rust-lang/backtrace-rs#656</a></li>
<li><a href="https://github.com/djc"><code>@​djc</code></a> made their
first contribution in <a
href="https://redirect.github.com/rust-lang/backtrace-rs/pull/657">rust-lang/backtrace-rs#657</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/rust-lang/backtrace-rs/compare/0.3.73...0.3.74">https://github.com/rust-lang/backtrace-rs/compare/0.3.73...0.3.74</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/38d49aa0395c50047ab26e418a0cb30d9955fb64"><code>38d49aa</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-lang/backtrace-rs/issues/658">#658</a>
from workingjubilee/cut-0.3.74</li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/c1749ce9a8cc0105b9d224e66f9ce4632133c1ea"><code>c1749ce</code></a>
Cut backtrace 0.3.74</li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/230570f2dac80a601f5c0b30da00cc9480bd35eb"><code>230570f</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-lang/backtrace-rs/issues/660">#660</a>
from workingjubilee/dont-unsoundly-iterate-phdr</li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/153f510013e9d486103dac7994d7f75205af397a"><code>153f510</code></a>
Do not destructure maybe-uninit fields</li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/38589464ed3a901794f5858ccbd7f996f6712f64"><code>3858946</code></a>
Revise dl_iterate_phdr callback to be sound-ish</li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/7d062c63749a4c07d9307c96b6cd9485ccd1ad18"><code>7d062c6</code></a><code>rust-lang/backtrace-rs#653</code></li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/fc37b22dc8a384d93f6b7b4817266eec6433875e"><code>fc37b22</code></a><code>rust-lang/backtrace-rs#657</code></li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/600beaa5074be0f40279584450d995c319061ce8"><code>600beaa</code></a><code>rust-lang/backtrace-rs#648</code></li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/84b6c1d56f4bd1b4297187db863c2db6d436c1cf"><code>84b6c1d</code></a><code>rust-lang/backtrace-rs#652</code></li>
<li><a
href="https://github.com/rust-lang/backtrace-rs/commit/95c3bacab9364620864208b651e77a524900480d"><code>95c3bac</code></a>
Make enum
<code>print::PrintFmt</code><code>rust-lang/backtrace-rs#651</code></li>
<li>Additional commits viewable in <a
href="https://github.com/rust-lang/backtrace-rs/compare/0.3.73...0.3.74">compare
view</a></li>
</ul>
</details>
<br />

Updates `serde` from 1.0.209 to 1.0.210
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/serde-rs/serde/releases">serde's
releases</a>.</em></p>
<blockquote>
<h2>v1.0.210</h2>
<ul>
<li>Support serializing and deserializing <code>IpAddr</code> and
<code>SocketAddr</code> in no-std mode on Rust 1.77+ (<a
href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>,
thanks <a
href="https://github.com/MathiasKoch"><code>@​MathiasKoch</code></a>)</li>
<li>Make <code>serde::ser::StdError</code> and
<code>serde::de::StdError</code> equivalent to
<code>core::error::Error</code> on Rust 1.81+ (<a
href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/serde-rs/serde/commit/89c4b02bf32ceae5b17d89f93a452ccc195ca038"><code>89c4b02</code></a>
Release 1.0.210</li>
<li><a
href="https://github.com/serde-rs/serde/commit/eeb8e44cda15f929796cd72241b0311e0bd04e67"><code>eeb8e44</code></a>
Merge pull request <a
href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>
from dtolnay/coreerror</li>
<li><a
href="https://github.com/serde-rs/serde/commit/785c2d9605ee73cc172dfd421228c1dccca984c9"><code>785c2d9</code></a>
Stabilize no-std StdError trait</li>
<li><a
href="https://github.com/serde-rs/serde/commit/d549f048e10bcb5e677afaf7b99d0ed3604b113b"><code>d549f04</code></a>
Reformat parse_ip_impl definition and calls</li>
<li><a
href="https://github.com/serde-rs/serde/commit/4c0dd63011434905265e2710bb9186e09e4f8ec2"><code>4c0dd63</code></a>
Delete attr support from core::net deserialization macros</li>
<li><a
href="https://github.com/serde-rs/serde/commit/26fb1341651c4e0ae4d58c675db3ca2a0d6e12c2"><code>26fb134</code></a>
Relocate cfg attrs out of parse_ip_impl and parse_socket_impl</li>
<li><a
href="https://github.com/serde-rs/serde/commit/07e614b52b5ab3387d86d3198e5f52cd1f5ff3cb"><code>07e614b</code></a>
Merge pull request <a
href="https://redirect.github.com/serde-rs/serde/issues/2817">#2817</a>
from dtolnay/corenet</li>
<li><a
href="https://github.com/serde-rs/serde/commit/b1f899fbe81f070803d9f7ca6e5d1cc3f19c9ea2"><code>b1f899f</code></a>
Delete doc(cfg) attribute from impls that are supported in no-std</li>
<li><a
href="https://github.com/serde-rs/serde/commit/b4f860e62767828beb3ef91721b6c56a31f9baad"><code>b4f860e</code></a>
Merge pull request <a
href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>
from MathiasKoch/chore/core-net</li>
<li><a
href="https://github.com/serde-rs/serde/commit/d940fe1b4934f097b0333dcb87bec5ee308d39cd"><code>d940fe1</code></a>
Reuse existing Buf wrapper as replacement for std::io::Write</li>
<li>Additional commits viewable in <a
href="https://github.com/serde-rs/serde/compare/v1.0.209...v1.0.210">compare
view</a></li>
</ul>
</details>
<br />

Updates `serde_json` from 1.0.127 to 1.0.128
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/serde-rs/json/releases">serde_json's
releases</a>.</em></p>
<blockquote>
<h2>1.0.128</h2>
<ul>
<li>Support serializing maps containing 128-bit integer keys to
serde_json::Value (<a
href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a>,
thanks <a
href="https://github.com/Mrreadiness"><code>@​Mrreadiness</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/serde-rs/json/commit/d96b1d9b643b49a0bb92a8cf280daf6aa08f37cc"><code>d96b1d9</code></a>
Release 1.0.128</li>
<li><a
href="https://github.com/serde-rs/json/commit/599228d5dc52a0f1595fe4bd901821f70d0317a5"><code>599228d</code></a>
Merge pull request <a
href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a>
from Mrreadiness/feat/add-hashmap-key-128-serializer</li>
<li><a
href="https://github.com/serde-rs/json/commit/5416cee6c5ad355907f6e9d5f6039b994c69f768"><code>5416cee</code></a>
feat: add support for 128 bit HashMap key serialization</li>
<li><a
href="https://github.com/serde-rs/json/commit/27a4ca9d7a62394fe8f0103f3d91de59f055a4c4"><code>27a4ca9</code></a>
Upload CI Cargo.lock for reproducing failures</li>
<li>See full diff in <a
href="https://github.com/serde-rs/json/compare/1.0.127...1.0.128">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ConradIrwin pushed a commit to zed-industries/zed that referenced this pull request Sep 19, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [backtrace](https://redirect.github.com/rust-lang/backtrace-rs) |
dependencies | patch | `0.3.73` -> `0.3.74` |
| [backtrace](https://redirect.github.com/rust-lang/backtrace-rs) |
dev-dependencies | patch | `0.3.73` -> `0.3.74` |

---

### Release Notes

<details>
<summary>rust-lang/backtrace-rs (backtrace)</summary>

###
[`v0.3.74`](https://redirect.github.com/rust-lang/backtrace-rs/releases/tag/0.3.74)

[Compare
Source](https://redirect.github.com/rust-lang/backtrace-rs/compare/0.3.73...0.3.74)

#### What's Changed

- QNX Neutrino 7.0 support, thanks to
[@&#8203;nyurik](https://redirect.github.com/nyurik) in
[rust-lang/backtrace-rs#648
- Cleaned up our Android support. This should massively improve
backtraces for ones with the API level sufficient to ship with
libunwind, etc. Unfortunately, it comes at the cost of dropping support
for older ones! Thanks to
[@&#8203;fengys](https://redirect.github.com/fengys) in
[rust-lang/backtrace-rs#656
- Made PrintFmt, which was using the `Enum::__NonExhaustiveVariant`
pattern, use `#[non_exhaustive]` for real. Don't @&#8203; me if you were
matching on that! Thanks to
[@&#8203;nyurik](https://redirect.github.com/nyurik) in
[rust-lang/backtrace-rs#651
- Massively cleaned up the windows code! We moved from winapi to
windows-sys with windows-targets thanks to
[@&#8203;CraftSpider](https://redirect.github.com/CraftSpider) and
[@&#8203;ChrisDenton](https://redirect.github.com/ChrisDenton) in
- Don't cast HANDLE to usize and back by
[@&#8203;CraftSpider](https://redirect.github.com/CraftSpider) in
[rust-lang/backtrace-rs#635
- Switch from `winapi` to `windows-sys` by
[@&#8203;CraftSpider](https://redirect.github.com/CraftSpider) in
[rust-lang/backtrace-rs#641
- Update windows bindings and use windows-targets by
[@&#8203;ChrisDenton](https://redirect.github.com/ChrisDenton) in
[rust-lang/backtrace-rs#653
- A bunch of updated dependencies. Thanks
[@&#8203;djc](https://redirect.github.com/djc) and
[@&#8203;khuey](https://redirect.github.com/khuey)!
- Sorry if you were testing this code in miri! It started yelling about
sussy casts. A lot. We did a bunch of internal cleanups that should make
it quiet down, thanks to
[@&#8203;workingjubilee](https://redirect.github.com/workingjubilee) in
[rust-lang/backtrace-rs#641
- Uhhh we had to tweak `dl_iterate_phdr` in
[rust-lang/backtrace-rs#660
after Android revealed it was... kind of unsound actually and not doing
things like checking for null pointers before making slices! WHOOPS!
Thanks to [@&#8203;saethlin](https://redirect.github.com/saethlin) for
implementing detection for precisely that in rustc! It's really hard to
find soundness issues in inherited codebases like this one...

#### New Contributors

- [@&#8203;CraftSpider](https://redirect.github.com/CraftSpider) made
their first contribution in
[rust-lang/backtrace-rs#635
- [@&#8203;fengys1996](https://redirect.github.com/fengys1996) made
their first contribution in
[rust-lang/backtrace-rs#656
- [@&#8203;djc](https://redirect.github.com/djc) made their first
contribution in
[rust-lang/backtrace-rs#657

**Full Changelog**:
rust-lang/backtrace-rs@0.3.73...0.3.74

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants