Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "crates.io: Dropping support for non-canonical downloads" blog post #1156

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 24, 2023

As discussed in the crates.io team meeting last week, we would like to sunset support for "non-canonical downloads" on crates.io. This blog post officially deprecates it with a cutoff date roughly a month from now.

Bildschirmfoto 2023-10-24 um 10 55 12

@rust-lang/crates-io r?

@rustbot

This comment was marked as resolved.

@Turbo87 Turbo87 force-pushed the non-canonical-downloads branch from 020aa45 to 6f0d845 Compare October 24, 2023 09:07
- GNU Guile
- python-requests/2.31.0

Three of these are just generic HTTP client libraries. [GNU Guile](https://www.gnu.org/software/guile/) is apparently a programming language, so most likely this is also a generic user-agent from a custom user program.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These downloads may be from GNU Guix, which is similar to Nix. It uses the Guille Lisp implementation as language to define build recipes in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, thanks for the context. I assume that means that potentially some of these build recipes would have to be fixed to use the canonical names?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume so. I don't use Guix myself, so you may want to ask someone who does or one of the Guix devs: https://guix.gnu.org/en/contribute/

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks fine (but please make sure team is happy with it :)

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to maybe prevent some questions/worries people might have

posts/2023-10-24-crates-io-non-canonical-downloads.md Outdated Show resolved Hide resolved
posts/2023-10-24-crates-io-non-canonical-downloads.md Outdated Show resolved Hide resolved
posts/2023-10-24-crates-io-non-canonical-downloads.md Outdated Show resolved Hide resolved
posts/2023-10-24-crates-io-non-canonical-downloads.md Outdated Show resolved Hide resolved
posts/2023-10-24-crates-io-non-canonical-downloads.md Outdated Show resolved Hide resolved
Turbo87 and others added 2 commits October 27, 2023 12:01
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
Copy link
Member

@jtgeibel jtgeibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to - vs _, crate names are case sensitive. Do we want to mention that as well? (Marking as approved because I'm fine merging as-is if we haven't actually seen casing differences show up in the logs.)

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 27, 2023

@jtgeibel very good point! I admit I had forgotten about that part. I've added another sentence to the blog post mentioning that.

@Turbo87 Turbo87 merged commit 2340640 into rust-lang:master Oct 27, 2023
2 checks passed
@Turbo87 Turbo87 deleted the non-canonical-downloads branch October 27, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants