Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.82.0 announcement post: Fix incorrect listed implementing type for inherent implementation containing newly stabilized std::rc::Rc::assume_init #1416

Conversation

schuelermine
Copy link
Contributor

@schuelermine schuelermine commented Oct 18, 2024

it’s not on Rc<T>

Rendered

… for inherent implementation containing newly stabilized std::rc::Rc::assume_init
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cuviper Do you concur?

@cuviper
Copy link
Member

cuviper commented Oct 21, 2024

Yes, and Arc needs the same fix a few lines down. These should also be fixed in the rust repo's RELEASES.md.

@cuviper
Copy link
Member

cuviper commented Oct 21, 2024

Oh, Box too!

@cuviper
Copy link
Member

cuviper commented Oct 22, 2024

These should also be fixed in the rust repo's RELEASES.md.

I've submitted this in rust-lang/rust#132040

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
Rollup merge of rust-lang#132040 - cuviper:assume_init-1.82, r=dtolnay

relnotes: fix stabilizations of `assume_init`

Ref: rust-lang/blog.rust-lang.org#1416
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I went ahead and pushed the change for the other two types.

@ehuss ehuss enabled auto-merge December 4, 2024 01:45
@ehuss ehuss merged commit 4f81deb into rust-lang:master Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants