This Month in Our Test Infra (Nov 2024 issue) #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Dec 3, 2024
|
boop @Mark-Simulacrum |
jieyouxu
force-pushed
the
tmioti-nov-2024
branch
from
fbe8984 to
54a2e6b
Compare
|
Rebased to today's date, no functional changes |
weihanglo
reviewed
Dec 9, 2024
|
|
||
| ### rustc: make `rustc` consider itself a stable compiler when `RUSTC_BOOTSTRAP=-1` is set | ||
|
|
||
| In [#132993](https://github.com/rust-lang/rust/pull/132993), I modified |
There was a problem hiding this comment.
Just a drive-by: Maybe using @jieyouxu instead of I?
- Make the post in a more neutral tone.
- Can immediately know who worked on this when reading
There was a problem hiding this comment.
I mean the post author is right there so lol. But yeah I'll try to use a more neutral representation next time.
There was a problem hiding this comment.
I feel like calling yourself out gives the right amount of credits to your work. People just likely pay less attention to post authors 😞
It's up to you anyway. I love the post. Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date range: 2024-11-05 to 2024-12-03
r? @Mark-Simulacrum (or @onur-ozkan)
Rendered