Skip to content

Make all hotlinked images local #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

Make all hotlinked images local #597

merged 1 commit into from
May 18, 2020

Conversation

Kestrer
Copy link
Contributor

@Kestrer Kestrer commented May 18, 2020

This closes #578 and half of #579.

The only remaining image hotlink is 2016-04-19-MIR, which has two references to hotlinked images in its Markdown that aren't used anywhere in the article.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@XAMPPRocky
Copy link
Member

XAMPPRocky commented May 18, 2020

@Koxiaet Thank you for your PR! Is there a reason this PR doesn't also remove the hotlinks in the MIR post?

@Kestrer
Copy link
Contributor Author

Kestrer commented May 18, 2020

@XAMPPRocky As it wasn't used I felt that it might be the job of another PR to remove all unused links in blog posts.

@XAMPPRocky
Copy link
Member

@Koxiaet Oh I didn't see the "aren't used anywhere in the article." part. It seems fine to leave then as it won't affect the readers.

Thank you again for your PR, and congrats on your first contribution!

@XAMPPRocky XAMPPRocky merged commit edb9896 into rust-lang:master May 18, 2020
jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One Year Of Rust post features wrong image.
4 participants