Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the disc list style type #683

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Use the disc list style type #683

merged 1 commit into from
Feb 23, 2024

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 1, 2020

Previously, it was the circle list style type, but it was determined
that the disc list style type is in many ways a better match for Rust.

See rust-lang/www.rust-lang.org#1252 and rust-lang/www.rust-lang.org#1254.

@camelid camelid requested a review from a team as a code owner September 1, 2020 02:57
@camelid
Copy link
Member Author

camelid commented Sep 1, 2020

Was this the right place to edit the styles? It's all in one line, which made me think it might not be, but I don't see any other place.

@steveklabnik
Copy link
Member

This file is imported from http://getskeleton.com/, so it is not the right place to modify the style.

@camelid
Copy link
Member Author

camelid commented Nov 25, 2020

So where should I change it if not here? Should I add a new CSS file that overrides this style?

@rylev
Copy link
Member

rylev commented Jun 22, 2022

@camelid I guess you were waiting to learn where to put these custom styles no? Do you still have any interest in seeing this land?

@camelid
Copy link
Member Author

camelid commented Jun 22, 2022

@rylev Yeah, I'm not sure where to change the style. It would be nice to see this through :)

Previously, it was the `circle` list style type, but it was determined
that the `disc` list style type is in many ways a better match for Rust.
@Turbo87
Copy link
Member

Turbo87 commented Feb 18, 2024

@camelid I've rebased this and moved the override to src/style/app.scss where we're already other styles

@Turbo87
Copy link
Member

Turbo87 commented Feb 18, 2024

Bildschirmfoto 2024-02-18 um 04 38 52 Bildschirmfoto 2024-02-18 um 04 38 38

r? @rust-lang/website

@Turbo87 Turbo87 merged commit 116d148 into rust-lang:master Feb 23, 2024
3 checks passed
@camelid camelid deleted the disc-list branch February 23, 2024 20:11
@camelid
Copy link
Member Author

camelid commented Feb 23, 2024

@Turbo87 wow, thanks so much! Glad this change has been made at last. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants