Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post for Rust 1.59.0 #931

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Feb 16, 2022

No description provided.

@tmandry tmandry requested a review from a team as a code owner February 16, 2022 19:46
@tmandry tmandry changed the title Rust 1.59.0 Blog post for Rust 1.59.0 Feb 16, 2022
@tmandry
Copy link
Member Author

tmandry commented Feb 16, 2022

cc @rust-lang/release

posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Show resolved Hide resolved
@tmandry tmandry force-pushed the rust-1-59 branch 2 times, most recently from 003b1b4 to c633d58 Compare February 20, 2022 08:20
@pietroalbini
Copy link
Member

We also need to mention that we disabled incremental compilation (rust-lang/rust#94124).

@estebank
Copy link
Contributor

It should also include information on how to enable it.

@Mark-Simulacrum
Copy link
Member

I pushed an initial section on incr comp -- would appreciate feedback, not sure how it reads just yet.

I also put it pretty far down, but we may want to raise it up higher in the post, not sure which is best.

posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor

For what is worth, the wording in the release notes isn't bad: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1590-2022-02-24

@Mark-Simulacrum
Copy link
Member

Yeah, maybe we can copy that. That's my yesterday-night take on it :)

Copy link
Member

@pierwill pierwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few suggestions :)

posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

Ok, I've updated the post to reflect feedback provided so far, and refactored the incremental section once more. I'm still unsure whether putting in essentially at the end of the post vs. the beginning makes sense -- I can see pros and cons to either strategy. I think it'll likely remain as-is unless there's strong feedback otherwise.

@matklad
Copy link
Member

matklad commented Feb 24, 2022

I feel we probably should tone down the announcement, the way we did for 1.44.0.

posts/2022-02-24-Rust-1.59.0.md Outdated Show resolved Hide resolved
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>
@Mark-Simulacrum Mark-Simulacrum merged commit 584a455 into rust-lang:master Feb 24, 2022
@tmandry tmandry deleted the rust-1-59 branch February 24, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.