-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post for Rust 1.59.0 #931
Conversation
cc @rust-lang/release |
003b1b4
to
c633d58
Compare
We also need to mention that we disabled incremental compilation (rust-lang/rust#94124). |
It should also include information on how to enable it. |
I pushed an initial section on incr comp -- would appreciate feedback, not sure how it reads just yet. I also put it pretty far down, but we may want to raise it up higher in the post, not sure which is best. |
For what is worth, the wording in the release notes isn't bad: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1590-2022-02-24 |
Yeah, maybe we can copy that. That's my yesterday-night take on it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few suggestions :)
4674d07
to
189d6e1
Compare
Ok, I've updated the post to reflect feedback provided so far, and refactored the incremental section once more. I'm still unsure whether putting in essentially at the end of the post vs. the beginning makes sense -- I can see pros and cons to either strategy. I think it'll likely remain as-is unless there's strong feedback otherwise. |
I feel we probably should tone down the announcement, the way we did for 1.44.0. |
963397f
to
a9a84ba
Compare
a9a84ba
to
153b509
Compare
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>
No description provided.