-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.60.0 blog post #952
Add 1.60.0 blog post #952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYVM for putting this together!
Co-authored-by: Eric Huss <eric@huss.org>
Co-authored-by: Eric Huss <eric@huss.org>
Co-authored-by: Eric Huss <eric@huss.org>
@ehuss Thanks! I think the new text is indeed better. Are there plans to make the default syntax the "thing you want"? I wonder if we could make a slight reference to the next edition there, for example. But probably isn't worth it. |
There are no plans at this time to change the behavior. It could be considered, but is currently not on our radar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleywiser - Thanks for putting this together! Some suggestions.
Looks good! |
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Pushed updates per @richkadel's review -- thanks! |
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
I think we need to add the Duration changes to the blog post. |
The Duration changes are now documented in the release notes; the corresponding section needs to get copied to the blog post. |
I pushed a section, but I'm not particularly happy with it. Maybe we just cut down on what it says to something more barebones, not sure. It may make sense to promote some more of the discussion in rust-lang/rust#89926 to here. |
I think the snippet you wrote works. @rust-lang/core can someone approve this so I can merge it tomorrow as part of the 1.60.0 release process? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some minor edits, no semantic changes.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
This just inlines the release notes from rust-lang/rust#94817, but they aren't yet ready -- several more rounds of revision will be necessary there.
cc @rust-lang/release
@pnkfelix @wesleywiser This contains a section on incr comp status; I wrote up some language presuming we leave things enabled, but that can be iterated based on future decisions -- maybe at next week's planning meeting. Happy to see revisions of the text there.