You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@steveklabnik I'm reading through your Vec PR and noticed you chose to use text as the syntax highlighting choice for many of the code blocks (I'm working on comments about the actual contents of the chapter but thought I'd open a new issue for this since it's orthogonal).
I don't know how code blocks are going to end up looking in print, but I really like the gray background that sets code/pseudocode/output apart from the prose in the rendered HTML.
I've been making error messages and output from running commands have bash as their type, since that gets the gray box. Can we make that a convention?
I get that the parts of the Vec chapter that show the approximate internal structure of Vecs are pseudocode and not valid rust, but would it hurt to have them marked as rust,ignore?
If you like them as text, can we change the CSS to make them have a gray background too pretty please? 🍨 🍒 :)
Assigning to @steveklabnik because I want his thoughts, STEVE DO NOT DO THE WORK FOR THIS ONCE WE DECIDE ON SOMETHING I'LL TAKE CARE OF IT ❤️ ❤️ ❤️ ❤️
The text was updated successfully, but these errors were encountered:
I've been making error messages and output from running commands have bash as their type, since that gets the gray box. Can we make that a convention?
Sure!
I get that the parts of the Vec chapter that show the approximate internal structure of Vecs are pseudocode and not valid rust, but would it hurt to have them marked as rust,ignore?
I was worried that the highlighting would screw up and it would look worse, but didn't check it.
Ok! between #203 and 11cb24b, I think we've got all current terminal output using bash syntax highlighting. I'm going to try and keep an eye on this as we add more content, and I've put it in the style guide i'm working on adding and I'm planning on checking through all of those things as we freeze chapters for print.
elahn
pushed a commit
to elahn/rust-book
that referenced
this issue
Aug 20, 2016
@steveklabnik I'm reading through your
Vec
PR and noticed you chose to usetext
as the syntax highlighting choice for many of the code blocks (I'm working on comments about the actual contents of the chapter but thought I'd open a new issue for this since it's orthogonal).I don't know how code blocks are going to end up looking in print, but I really like the gray background that sets code/pseudocode/output apart from the prose in the rendered HTML.
I've been making error messages and output from running commands have
bash
as their type, since that gets the gray box. Can we make that a convention?I get that the parts of the
Vec
chapter that show the approximate internal structure ofVec
s are pseudocode and not valid rust, but would it hurt to have them marked asrust,ignore
?If you like them as
text
, can we change the CSS to make them have a gray background too pretty please? 🍨 🍒 :)Assigning to @steveklabnik because I want his thoughts, STEVE DO NOT DO THE WORK FOR THIS ONCE WE DECIDE ON SOMETHING I'LL TAKE CARE OF IT ❤️ ❤️ ❤️ ❤️
The text was updated successfully, but these errors were encountered: