Skip to content

CI: stable/nightly #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steveklabnik opened this issue Mar 23, 2017 · 0 comments
Closed

CI: stable/nightly #558

steveklabnik opened this issue Mar 23, 2017 · 0 comments

Comments

@steveklabnik
Copy link
Member

We are gonna need rust-lang/reference#14 as well.
@steveklabnik steveklabnik mentioned this issue Mar 23, 2017
Merged
steveklabnik added a commit that referenced this issue Mar 23, 2017
@steveklabnik
Check that we don't use any unstable features.
0a22f71 
We need to track Rust master, but don't want to cover unstable things.
As such, a new lint, `stable-check`, is added.

The second edition was already lint clean, but the first needed some
tweaks:

1. The closures chapter was showing off details of the closure traits,
   so just don't do that.
2. The FFI chapter was using internal libc to compile the tests, so just
   don't compile them anymore.
3. The compiler plugins chapter was vestigial and was moved to the
   unstable book.

Fixes #558
@steveklabnik steveklabnik mentioned this issue Mar 23, 2017
Merged
steveklabnik added a commit that referenced this issue Mar 23, 2017
@steveklabnik
Check that we don't use any unstable features.
59f76f1 
We need to track Rust master, but don't want to cover unstable things.
As such, a new lint, `stable-check`, is added.

The second edition was already lint clean, but the first needed some
tweaks:

1. The closures chapter was showing off details of the closure traits,
   so just don't do that.
2. The FFI chapter was using internal libc to compile the tests, so just
   don't compile them anymore.
3. The compiler plugins chapter was vestigial and was moved to the
   unstable book.

Fixes #558
gypsydave5 pushed a commit to gypsydave5/book that referenced this issue Nov 17, 2017
@steveklabnik @gypsydave5
Check that we don't use any unstable features.
005d8a2 
We need to track Rust master, but don't want to cover unstable things.
As such, a new lint, `stable-check`, is added.

The second edition was already lint clean, but the first needed some
tweaks:

1. The closures chapter was showing off details of the closure traits,
   so just don't do that.
2. The FFI chapter was using internal libc to compile the tests, so just
   don't compile them anymore.
3. The compiler plugins chapter was vestigial and was moved to the
   unstable book.

Fixes rust-lang#558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steveklabnik