Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to address ? and Option #1713

Closed
wants to merge 1 commit into from

Conversation

arienmalec
Copy link

I updated the documentation to address issue #1679. This is a semi-functional fix, I'm looking for feedback on:

  1. If this documentation makes sense, fits the flow of The Book, and is the right tone and style
  2. How to address cross referencing (I put a bunch of [REF] placeholders in there
  3. Technical accuracy (I compiled all the code samples, but I'm not sure that I have all the technical details right -- particularly the discussion of ownership and moves as well as the details of the ? rewrite in an Option context.

@steveklabnik
Copy link
Member

Hey there! I really really appreciate this PR! Unfortunately, we can't take really large changes like this. Thank you and sorry.

@dralley
Copy link
Contributor

dralley commented Jan 18, 2019

@steveklabnik would you consider keeping the wording and stripping down the examples (which are about 3/4 of the diff)?

@dralley
Copy link
Contributor

dralley commented Jan 29, 2019

@steveklabnik ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants