Reword ch01-03 recap paragraph #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cargo check does build your project, it just does not do the final step of turning it into binary code. I sympathize with the aims here, but I'd prefer a tweaked wording. |
The original wording suggests that cargo check builds a project. The new wording makes it clear what its actual functionality is.
rxlecky
force-pushed
the
reword-ch01-03-recap
branch
from
8517f6f to
c22d403
Compare
|
Ahh, I hear ya! Good point, it's important to not oversimplify things. This is the new proposed wording:
|
|
The revisited version looks good to me. And less humble: _the pull request should be granted. |
|
Haha, what is the chance I would get a PR review by a Bredanaar :) |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 8, 2020
Update books ## nomicon 3 commits in d1517d4e3f29264c5c67bce2658516bb5202c800..bfe1ab96d717d1dda50e499b360f2e2f57e1750a 2020-05-12 13:47:00 -0400 to 2020-06-05 13:19:42 -0400 - Clarify that str data must still be initialized - Remove language-level UB for non-UTF-8 str - fix Nomicon transmute UB ## reference 5 commits in becdca9477c9eafa96a4eea5156fe7a2730d9dd2..5d40ba5c2515caffa7790cda621239dc21ef5a72 2020-05-21 21:08:02 +0100 to 2020-06-06 20:25:36 -0700 - Add some links to Disambiguating Function Calls. (rust-lang/reference#829) - change bash to sh as shell code blocks language indentifier (rust-lang/reference#827) - Fix sentence mistake in array-expr.md (rust-lang/reference#826) - removed the word "Second" form the beginning of the 2nd list item and labelled it as `2` (rust-lang/reference#822) - Update fn-like proc-macro invocation restrictions. (rust-lang/reference#816) ## book 14 commits in e8a4714a9d8a6136a59b8e63544e149683876e36..30cd9dfe71c446de63826bb4472627af45acc9db 2020-05-25 10:29:27 -0500 to 2020-06-07 23:07:19 -0500 - Unnecessarily long type name in Ch 13 (rust-lang/book#2362) - Tweak example in chapter 10 (rust-lang/book#2363) - Mention that to_lowercase isn't perfect (rust-lang/book#2364) - fix typo in CONTRIBUTING.md (rust-lang/book#2360) - Link German translation in appendix F (rust-lang/book#2347) - Updates wording on Box example (rust-lang/book#2332) - fix: match 15-24 with 15-18 (rust-lang/book#2324) - Reword ch01-03 recap paragraph (rust-lang/book#2305) - Remove some confusing wording. (rust-lang/book#2358) - Clarify some wording a bit (rust-lang/book#2357) - Update ch12-05 PowerShell note (rust-lang/book#2348) - text -> console (rust-lang/book#2352) - Improve wording around drop (rust-lang/book#2350) - Make some statements about crates more correct (rust-lang/book#2349) ## edition-guide 1 commits in 0a8ab5046829733eb03df0738c4fafaa9b36b348..82bec5877c77cfad530ca11095db4456d757f668 2020-05-18 08:34:23 -0500 to 2020-06-03 08:56:02 -0500 - Add stuff for Rust 1.33 (rust-lang/edition-guide#214)
|
I am not sure I should comment on a merged pull request, but I ended here while considering to submit one myself with the removal of the "build" word of the sentence because I also thought that I think the following alternative is tweaked wording enough to move the reader away from the issue wether
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original wording suggests that
cargo checkbuilds a project. The new wording makes it clear what its actual functionality is.