Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Content-Length header to Ch 20-01 listings. #2589

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

apogeeoak
Copy link
Contributor

Added Content-Length header to listing 20-07 and listing 20-09. Removed the explanation about not returning headers.

When the Content-Length header was added in listing 20-05 for the success case in #2246 the Content-Length header was not added to the error case in listing 20-07 or the refactored code in listing 20-09.

References #1324
Closes #2434

@apogeeoak
Copy link
Contributor Author

The same change is applied to multiple files. Most of the changes are hidden behind snips but the change is visible in listings 20-07, 20-09, 20-10, and no-listing-08-final-code.

@carols10cents carols10cents merged commit ebb817e into rust-lang:master Feb 10, 2021
@carols10cents
Copy link
Member

Thank you, this was a big help! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter 20.1: Content-Length header is dropped between Listing 20-5 and 20-9
2 participants