-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spellchecker script #338
Conversation
So I'm trying this out, and I think I'm confused or doing something wrong :( I decided to update the dictionary to get the latest valid words we use that are not spelling errors. So I removed the current dictionary ( Then i did a |
@carols10cents IIRC I used the same script. But it is possible that I added some words and forgot to sort it after that. I'll try to regenerate it now. |
@carols10cents strange, it generates almost the same file for me. The only issue I spotted is that I removed sort words (length <= 3) from dictionary, but forgot to remove them from dictionary generator. Fixing it now. Maybe, we have some weirdly differents
|
Short words should not appear in dictionary now. You described perfectly valid assumptions, I agree that it should work like this. And it works for me. We should investigate how it behaves on different machines. I am on Fedora 25 now, and it is fine with sort here ( |
Oh geez. It looks like an I'm going to need a bit more time to investigate my options for fixing this, but at this point it seems like it's going to be a solution on my end, not yours. I'm just going to leave this open for a little bit to see if I have a way I can reproduce the dictionary. If I can't figure something out in a few days, I'll merge and deal. |
I decided I don't feel like figuring out LC_COLLATE; I just won't use aspell's interactive dictionary adding; nor will I regenerate dictionary.txt from scratch. I want this too much :) Thank you so much for your work on this, you're going to save us from so many embarrassing typos and misspellings!!!!! ❤️ ❤️ ❤️ ❤️ ❤️ |
@carols10cents Yay, glad to hear that! Feel free to cc me if you will have any problems/suggestions for this spellchecker. |
This patches add spellchecker script and integrates it into CI. See README.txt and comments in the beginning of a script for usage details.
Fixes #118