Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch13-03: Use correct variable name #3448

Closed
wants to merge 1 commit into from

Conversation

brunojppb
Copy link

Hey Rust folks 👋 ,

First of, thanks for this amazing book! Now onto this tiny fix.
The code where this paragraph references to uses file_path instead of filename as the variable name:

let file_path = match args.next() {
Some(arg) => arg,
None => return Err("Didn't get a file path"),

This fix should use the matching variable name according to the Rust code.

@brunojppb brunojppb changed the title Use correct variable name [ch13-03] Use correct variable name Dec 4, 2022
@brunojppb brunojppb changed the title [ch13-03] Use correct variable name ch13-03: Use correct variable name Dec 4, 2022
@brunojppb brunojppb force-pushed the fix-variable-name-typo branch from c0fe924 to 5be36ba Compare December 4, 2022 11:50
@carols10cents
Copy link
Member

Thank you, closing as a duplicate of #3457 though. Please check existing PRs and issues before opening new ones in the future. Thanks!

@brunojppb
Copy link
Author

Thank you, closing as a duplicate of #3457 though. Please check existing PRs and issues before opening new ones in the future. Thanks!

Thank you @carols10cents 🙌
I actually checked the opened PRs and didn't find one addressing this issue already. (the one you referenced was created on a later date)
But is good to keep that in mind.

@carols10cents
Copy link
Member

Whoops, sorry about that, I thought I had the list sorted and picked the oldest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants