Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrote part of Ch 13, closures and iterators #381

Closed
wants to merge 6 commits into from

Conversation

AdamCDunlap
Copy link
Contributor

No description provided.

@alex-ozdemir
Copy link

😄

@alex-ozdemir
Copy link

Perhaps you want to add FnOnce, FnMut, and IntoIterator to dictionary.txt? (And perhaps Fn as well, even though ispell doesn't seem to mind.

@carols10cents
Copy link
Member

Thanks! We'll be working on incorporating this soon. Just a heads up, we're probably going to be making some pretty substantial changes to match what we've planned for the structure of this chapter, how in depth it will go, and to make the tone consistent with the rest of the book. We've got ideas that are hard to convey clearly to people who haven't been as involved with the whole process. If you're planning on contributing more in the future, we should have a chat about what we're looking for. In general, smaller is better, a whole chapter is a lot to attempt! For example, contributing code snippets that could demonstrate various ideas would be more helpful and potentially a better use of your time. I think we'll definitely be using some of yours here!

@steveklabnik steveklabnik mentioned this pull request Jan 10, 2017
@steveklabnik
Copy link
Member

@AdamCDunlap thank you! I've taken your work and made #395 out of it; I was able to re-use some of your example code. Please check it out and let us know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants