Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc-dev component option #101

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Jul 22, 2020

Fixes #100
I added a --with-dev option to download rustc-dev.
Because of rust-lang/rust#72594 I also install llvm-tools together with rustc-dev

@ehuss
Copy link
Collaborator

ehuss commented Jul 22, 2020

Maybe it would be more flexible to add a --component flag similar to rustup-toolchain-install-master so that you can specify any component?

@Mark-Simulacrum
Copy link
Member

Yeah I think that would probably be the way to go, and we can still do some auto-detection for installing llvm-tools-preview.

It might also be good to consider dropping our custom installation code in favor of forking out to rustup-toolchain-install-master, and documenting that as a pre-req for bisection. (Maybe we can get a library version of it published, too).

@spastorino
Copy link
Member

What is the status of this? cc @elichai

@elichai
Copy link
Contributor Author

elichai commented Oct 25, 2020

@spastorino not sure what's the next step, can it be merged as is? or do we want the --component flag? or maybe depend on rustup-toolchain-install-master somehow?

@spastorino
Copy link
Member

Maybe @ehuss or @Mark-Simulacrum can clarify a bit and guide you better than I

@Mark-Simulacrum
Copy link
Member

I think we should probably just merge. While I continue to think that a general component flag is the way to go, this is still likely a useful step. Ultimately I do think it makes sense for us to find a way to avoid a bunch of tools repeating the rustup-toolchain-install-master-like logic to install a set of rustup components for a particular commit; perhaps that means rustup-toolchain-install-master should become a library instead of just a cargo-install command, not sure.

@spastorino spastorino merged commit 45b29a5 into rust-lang:master Nov 4, 2020
@elichai elichai deleted the 2020-07-rustc-dev branch November 4, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the rustc-dev component
4 participants