Show additional context for unrolled perf builds bisections #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the commit has been GC'ed on github, the user would need to map back from the commit to the PR by looking at the comment posted by the bot. This PR automates this, and displays the PR number and title (when available) in addition to the perf build commit.
In case we can't find any context, we panic and ask to open an issue. I'm not enamored with that but it's better in my mind than parsing and displaying an incorrect context (ensuring we have the same number of commits and descriptions).
This should only happen on incredibly rare events where the comment doesn't match either the v1 or v2 structure, and if that happens, the bisection would fail or its results would be bogus, so I think it's fine. (The other case is that there could be a bug in the parsing, which we could find only by it failing in the wild and people opening issues pointing at the unexpected perfbot comment).
This should show the PR number for v1, and the number and title for the current v2.
Fixes #294.