Skip to content

Commit

Permalink
Auto merge of #11610 - ehuss:disable-public-network-windows, r=epage
Browse files Browse the repository at this point in the history
Disable network SSH tests on windows.

These tests have a high failure rate on Windows, so this disables them for now. I don't know exactly why they are failing. If I had to take a wild guess, I would suspect the use of WinCNG for the SSH backend, which may mean it is out of our control.
  • Loading branch information
bors committed Jan 21, 2023
2 parents 7e2a3c2 + ede3bdf commit 2741053
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/testsuite/ssh.rs
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,10 @@ Caused by:
}

#[cargo_test(public_network_test)]
// For unknown reasons, this test occasionally fails on Windows with a
// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error:
// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23)
#[cfg_attr(windows, ignore = "test is flaky on windows")]
fn invalid_github_key() {
// A key for github.com in known_hosts should override the built-in key.
// This uses a bogus key which should result in an error.
Expand Down Expand Up @@ -417,6 +421,10 @@ fn invalid_github_key() {
}

#[cargo_test(public_network_test)]
// For unknown reasons, this test occasionally fails on Windows with a
// LIBSSH2_ERROR_KEY_EXCHANGE_FAILURE error:
// failed to start SSH session: Unable to exchange encryption keys; class=Ssh (23)
#[cfg_attr(windows, ignore = "test is flaky on windows")]
fn bundled_github_works() {
// The bundled key for github.com works.
//
Expand Down

0 comments on commit 2741053

Please sign in to comment.