Skip to content

Commit

Permalink
Auto merge of #10254 - joshtriplett:rmeta-required-no-timings, r=alex…
Browse files Browse the repository at this point in the history
…crichton

Make rmeta_required no longer depend on whether timing is enabled

This doesn't appear to affect the quality of the timing information at
all.

If there's additional information we need from rustc about what it's
doing at any given time, we could add mechanisms to retrieve that
information, but enabling timing shouldn't force building more than we
otherwise would have.
  • Loading branch information
bors committed Jan 4, 2022
2 parents 5084072 + 25d1480 commit 358e79f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cargo/core/compiler/context/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ impl<'a, 'cfg> Context<'a, 'cfg> {
/// Returns whether when `unit` is built whether it should emit metadata as
/// well because some compilations rely on that.
pub fn rmeta_required(&self, unit: &Unit) -> bool {
self.rmeta_required.contains(unit) || self.bcx.config.cli_unstable().timings.is_some()
self.rmeta_required.contains(unit)
}

pub fn new_jobserver(&mut self) -> CargoResult<Client> {
Expand Down

0 comments on commit 358e79f

Please sign in to comment.