Skip to content

Commit

Permalink
fix(resolver): In errors, show rejected versions over alt versions (#…
Browse files Browse the repository at this point in the history
…14923)

### What does this PR try to resolve?

The user likely intended what they said and we should tell them why it
didn't work.
Rejected versions also imply alt versions below them.

Fixes #4260

In changing the errors from alt-versions to rejected-versions, I found
part of the old error message was better and changed the message
introduced in #14897 from matching alt-names to alt-versions.

This includes the test for #14921. The "fix" was done before this
because as it was part of the refactors in prep for this.

### How should we test and review this PR?

### Additional information

Next steps after this are to still produce an
`IndexSummary::Unsupported` even if there are deserialization errors, so
long as we know the name and version which should take care of #10623
and #14894.
  • Loading branch information
ehuss authored Dec 12, 2024
2 parents 351b421 + ccc00ce commit 4412b0a
Show file tree
Hide file tree
Showing 3 changed files with 212 additions and 165 deletions.
Loading

0 comments on commit 4412b0a

Please sign in to comment.