Merge branch 'master' into yerke/no-run-test-executable-path

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,43 @@
+name: Bug Report
+description: Create a report to help us improve
+labels: ["C-bug"]
+body:
+ - type: markdown
+ attributes:
+ value: Thanks for filing a 🐛 bug report 😄!
+ - type: textarea
+ id: problem
+ attributes:
+ label: Problem
+ description: >
+ Please provide a clear and concise description of what the bug is,
+ including what currently happens and what you expected to happen.
+ validations:
+ required: true
+ - type: textarea
+ id: steps
+ attributes:
+ label: Steps
+ description: Please list the steps to reproduce the bug.
+ placeholder: |
+ 1.
+ 2.
+ 3.
+ - type: textarea
+ id: possible-solutions
+ attributes:
+ label: Possible Solution(s)
+ description: >
+ Not obligatory, but suggest a fix/reason for the bug,
+ or ideas how to implement the addition or change.
+ - type: textarea
+ id: notes
+ attributes:
+ label: Notes
+ description: Provide any additional notes that might be helpful.
+ - type: textarea
+ id: version
+ attributes:
+ label: Version
+ description: Please paste the output of running `cargo version --verbose`.
+ render: text

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,10 @@
+contact_links:
+ - name: Question
+ url: https://users.rust-lang.org
+ about: >
+ Got a question about Cargo? Ask the community on the user forum.
+ - name: Inspiring Idea
+ url: https://internals.rust-lang.org/c/tools-and-infrastructure/cargo
+ about: >
+ Need more discussions with your next big idea?
+ Reach out the coummunity on the internals forum.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -0,0 +1,35 @@
+name: Feature Request
+description: Suggest an idea for enhancing Cargo
+labels: ["C-feature-request"]
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for filing a 🙋 feature request 😄!
+
+ If the feature request is relatively small and already with a possible solution, this might be the place for you.
+
+ If you are brewing a big feature that needs feedback from the community, [the internal forum] is the best fit, especially for pre-RFC. You can also talk the idea over with other developers in [#t-cargo Zulip stream].
+
+ [the internal forum]: https://internals.rust-lang.org/c/tools-and-infrastructure/cargo/15
+ [#t-cargo Zulip stream]: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo
+ - type: textarea
+ id: problem
+ attributes:
+ label: Problem
+ description: >
+ Please provide a clear description of your use case and the problem
+ this feature request is trying to solve.
+ validations:
+ required: true
+ - type: textarea
+ id: solution
+ attributes:
+ label: Proposed Solution
+ description: >
+ Please provide a clear and concise description of what you want to happen.
+ - type: textarea
+ id: notes
+ attributes:
+ label: Notes
+ description: Provide any additional context or information that might be helpful.

.github/ISSUE_TEMPLATE/tracking_issue.yml

@@ -0,0 +1,50 @@
+name: Tracking Issue
+description: A tracking issue for an accepted feature or RFC in Cargo.
+title: "Tracking Issue for _FEATURE_NAME_"
+labels: ["C-tracking-issue"]
+body:
+ - type: markdown
+ attributes:
+ value: >
+ Thank you for creating a tracking issue! Tracking issues are for tracking an
+ accepted feature or RFC from implementation to stabilization. Please do not
+ file a tracking issue until the feature or RFC has been approved.
+ - type: textarea
+ id: summary
+ attributes:
+ label: Summary
+ description: Please provide a very brief summary of the feature.
+ value: |
+ RFC: [#NNNN](https://github.com/rust-lang/rfcs/pull/NNNN) <!-- If this is an RFC -->
+ Original issue: #NNNN <!-- if there is a related issue that spawned this feature -->
+ Implementation: #NNNN <!-- link to the PR that implemented this feature if applicable -->
+ Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#my-feature
+
+ Please enter a short, one-sentence description here.
+ validations:
+ required: true
+ - type: textarea
+ id: unresolved
+ attributes:
+ label: Unresolved Issues
+ description: List issues that have not yet been resolved.
+ placeholder: |
+ * [ ] Make a list of any known implementation or design issues.
+ - type: textarea
+ id: future
+ attributes:
+ label: Future Extensions
+ description: >
+ An optional section where you can mention where the feature may be
+ extended in the future, but is explicitly not intended to
+ address.
+ - type: textarea
+ id: about
+ attributes:
+ label: About tracking issues
+ description: Please include this notice in the issue.
+ value: |
+ Tracking issues are used to record the overall progress of implementation.
+ They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
+ A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
+ Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

.github/workflows/main.yml

@@ -19,7 +19,7 @@ jobs:
  - run: rustup component add rustfmt
  - run: cargo fmt --all -- --check
  - run: |
- for manifest in `find crates -name Cargo.toml`
+ for manifest in `find crates benches/benchsuite benches/capture -name Cargo.toml`
  do
  echo check fmt for $manifest
  cargo fmt --all --manifest-path $manifest -- --check
@@ -68,7 +68,9 @@ jobs:
 
  # Deny warnings on CI to avoid warnings getting into the codebase.
  - run: cargo test --features 'deny-warnings'
- - run: cargo test --features 'deny-warnings' -p cargo-test-support
+ - run: cargo test --features 'deny-warnings' --manifest-path crates/cargo-test-support/Cargo.toml
+ env:
+ CARGO_TARGET_DIR: target
  - run: cargo test -p cargo-platform
  - run: cargo test -p cargo-util
  - run: cargo test --manifest-path crates/mdman/Cargo.toml
@@ -79,6 +81,15 @@ jobs:
  if: matrix.os == 'macos-latest'
  - run: cargo build --manifest-path crates/credential/cargo-credential-wincred/Cargo.toml
  if: matrix.os == 'windows-latest'
+ - name: Check benchmarks
+ env:
+ # Share the target dir to try to cache a few build-time deps.
+ CARGO_TARGET_DIR: target
+ run: |
+ # This only tests one benchmark since it can take over 10 minutes to
+ # download all workspaces.
+ cargo test --manifest-path benches/benchsuite/Cargo.toml --all-targets -- cargo
+ cargo check --manifest-path benches/capture/Cargo.toml
  - name: Fetch smoke test
  run: ci/fetch-smoke-test.sh
 
@@ -104,6 +115,7 @@ jobs:
  steps:
  - uses: actions/checkout@v2
  - run: rustup update nightly && rustup default nightly
+ - run: rustup update stable
  - run: rustup component add rust-docs
  - run: ci/validate-man.sh
  # This requires rustfmt, use stable.