-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows OpenSSH ssh-agent not Supported by cargo from rustup #10237
Labels
C-bug
Category: bug
Comments
I have posted rust-lang/rust#92374 to update it. |
Ah, releases use the lock file from the main Rust repo, that makes sense. Thank you for making the PR. |
bors
added a commit
that referenced
this issue
Jan 2, 2022
Update docs for windows ssh-agent. This updates the documentation for SSH authentication using Windows and ssh-agent. Per #10237 and rust-lang/rust#92374, Cargo now supports ssh-agent on Windows. I'm about 80% sure this information is correct based on my reading of the code and testing. The ssh-agent that is part of mingw (or git-for-windows) uses emulated sockets, which are not compatible with traditional Windows-style named pipes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Support for the Windows OpenSSH
ssh-agent
was added tolibssh2
with libssh2/libssh2@c998f79 and added tolibssh2-sys
with version0.2.22
(alexcrichton/ssh2-rs@3fe863b).libssh2-sys 0.2.23
looks to have been included at least sincecargo 1.57.0
based on CI builds.All that said, the copy of
cargo
pulled down byrustup
doesn't seem to include a new enough version oflibssh2-sys
to include support for Windows OpenSSH. This can be confirmed by searching the binary for the string"openssh-ssh-agent"
as this string must be in the binary to be able to talk to the agent. A similar string for Pageant ("PageantRequest"
) can be find in the binary fromrustup
.Lastly, building
cargo
from source from the same commit as the binary pulled byrustup
works fine.Steps
No response
Possible Solution(s)
There may be a difference between the CI builds and those used for releases. If so, it may be that the version of
libssh2-sys
has been pinned either throughCargo.lock
or some other means and needs to be updated.Notes
No response
Version
The text was updated successfully, but these errors were encountered: