Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in cargo_util 0.1.3, in semver-minor version! #10803

Closed
steffahn opened this issue Jun 30, 2022 · 4 comments
Closed

Breaking change in cargo_util 0.1.3, in semver-minor version! #10803

steffahn opened this issue Jun 30, 2022 · 4 comments
Labels
C-bug Category: bug P-high Priority: High regression-from-stable-to-stable Regression in stable that worked in a previous stable release.

Comments

@steffahn
Copy link
Member

steffahn commented Jun 30, 2022 •
edited
Loading

Problem

ProcessBuilder::get_args returns an impl Iterator<Item = &OsString> now, whereas previously, it returned &[OsString].

This has the effect that non-locked builds of cargo-outdated and cargo-geiger fail (these crates are depending on cargo 1.61 or 1.60).
@steffahn steffahn added the C-bug Category: bug label Jun 30, 2022
@steffahn steffahn mentioned this issue Jun 30, 2022
Closed
@ehuss
Copy link
Contributor

ehuss commented Jun 30, 2022

Apologies for that, we need to be more vigilant in handling versions around here.

I'll start the process of getting a version bump and yanking 0.1.3 of cargo-util.

This was referenced Jun 30, 2022
Merged
Merged
Merged
@ehuss ehuss added P-high Priority: High regression-from-stable-to-stable Regression in stable that worked in a previous stable release. labels Jun 30, 2022
@smoelius smoelius mentioned this issue Jun 30, 2022
Closed
bors added a commit that referenced this issue Jul 1, 2022
@bors
Auto merge of #10806 - ehuss:bump-cargo-util-stable-1.62, r=joshtriplett
d39343d 
[STABLE-1.62] Bump cargo util stable

This is a stable backport of #10804. This uses version 0.2.0 compared to 0.2.1 on beta since beta has had some minor (compatible) changes.

cc #10803
bors added a commit that referenced this issue Jul 1, 2022
@bors
Auto merge of #10805 - ehuss:bump-cargo-util-beta-1.63, r=joshtriplett
542ba27 
[BETA-1.63] Bump cargo-util version.

This is a beta backport of #10804.  There is no version different between here and #10804 as there haven't been any changes since the branch was made a week ago.

cc #10803
@sdroege sdroege mentioned this issue Jul 1, 2022
Closed
@ehuss
Copy link
Contributor

ehuss commented Jul 1, 2022

I have yanked cargo-util 0.1.3 and cargo 0.63.0 and published new versions (0.2.0 and 0.63.1 respectively).
Please let me know if you have any issues.

Closing as fixed by #10806.

@ehuss ehuss closed this as completed Jul 1, 2022
bors added a commit that referenced this issue Jul 1, 2022
@bors
Auto merge of #10804 - ehuss:bump-cargo-util, r=joshtriplett
501b56b 
Bump cargo-util version.

#10546 made a semver-incompatible change to the API of `ProcessBuilder::get_args`. Unfortunately we did not catch that until it was published. This bumps the version of cargo-util to 0.2.1 to accommodate that change. Stable will get version 0.2.0 so that the changes on beta can be released as 0.2.1 in their own time.

cc #10803
@sdroege
Copy link
Contributor

sdroege commented Jul 1, 2022

That fixes it, thanks!

@steffahn
Copy link
Member Author

steffahn commented Jul 1, 2022

Can confirm this resolves the problems :-)

@epage epage mentioned this issue Jul 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug P-high Priority: High regression-from-stable-to-stable Regression in stable that worked in a previous stable release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @sdroege @steffahn