Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfix: Fix Windows tests #13033

Closed
ehuss opened this issue Nov 22, 2023 · 1 comment · Fixed by #13042
Closed

rustfix: Fix Windows tests #13033

ehuss opened this issue Nov 22, 2023 · 1 comment · Fixed by #13042
Labels
A-testing-cargo-itself Area: cargo's tests Command-fix O-windows OS: Windows S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@ehuss
Copy link
Contributor

ehuss commented Nov 22, 2023

For some reason, the parse_and_replace test of rustfix is disabled on Windows. I don't know why, but it would be nice for someone to investigate and fix that.
@ehuss ehuss added O-windows OS: Windows A-testing-cargo-itself Area: cargo's tests S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review Command-fix labels Nov 22, 2023
@tompscanlan
Copy link
Contributor

After removing the #![cfg(not(windows))] on line 2, tests will run on win11 powershell. 1 test passes, one test is ignored. Ignored test requires a "custom rustc build" but I'm not sure what that would entail and don't see it in cursory docs scan.

This may be another case like #13034... fix it and keep an eye out for flaky tests.

@tompscanlan tompscanlan mentioned this issue Nov 23, 2023
Merged
@bors bors closed this as completed in 527b35e Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing-cargo-itself Area: cargo's tests Command-fix O-windows OS: Windows S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try running on windows
2 participants
@ehuss @tompscanlan