-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfix
: Fix ignored tests
#13034
Labels
A-testing-cargo-itself
Area: cargo's tests
Command-fix
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Comments
ehuss
added
A-testing-cargo-itself
Area: cargo's tests
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Command-fix
labels
Nov 22, 2023
This was referenced Nov 23, 2023
bors
added a commit
that referenced
this issue
Nov 26, 2023
review and remove ignored tests in rustfix ### What does this PR try to resolve? review ignored tests in rustfix crate per #13034. ### How should we test and review this PR? CI testing ### Additional information * Removed unproductive test in `parse_and_replace` * un-ignore proptests, and reduce runtime from ~2s to ~<.25s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testing-cargo-itself
Area: cargo's tests
Command-fix
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
For some reason, several tests in rustfix are ignored:
edition
tests: https://github.com/rust-lang/cargo/blob/65d0eb536dd4a7ae6ddc50ca14556896e450c4ff/crates/rustfix/tests/parse_and_replace.rs#L242C1-L247. There don't appear to be any edition tests, so I think all of that should just be removed.cargo/crates/rustfix/src/replace.rs
Lines 313 to 335 in 65d0eb5
#[ignore]
. This needs a little investigation, just to make sure these tests aren't flaky or anything.The text was updated successfully, but these errors were encountered: