-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo add to package within a virtual workspace behaves differently when translating package name #13702
Labels
C-bug
Category: bug
Command-add
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Comments
dohse
added
C-bug
Category: bug
S-triage
Status: This issue is waiting on initial triage.
labels
Apr 4, 2024
epage
added
Command-add
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
and removed
S-triage
Status: This issue is waiting on initial triage.
labels
Apr 10, 2024
The root cause is the same as #10680. See that for more insight |
dohse
pushed a commit
to dohse/cargo
that referenced
this issue
Apr 13, 2024
dohse
pushed a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
pushed a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
4 tasks
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Apr 17, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
May 1, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
May 1, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
May 1, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
May 2, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
May 2, 2024
epage
pushed a commit
to dohse/cargo
that referenced
this issue
Aug 28, 2024
epage
pushed a commit
to dohse/cargo
that referenced
this issue
Aug 28, 2024
epage
pushed a commit
to dohse/cargo
that referenced
this issue
Aug 28, 2024
epage
pushed a commit
to dohse/cargo
that referenced
this issue
Aug 28, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 29, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 30, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 30, 2024
dohse
added a commit
to dohse/cargo
that referenced
this issue
Aug 30, 2024
bors
added a commit
that referenced
this issue
Sep 3, 2024
Fix cargo add behaving different when translating package name Fixes #13702 Fixes #10680 TODOs - [x] ~Fuzzy match registry dependencies in `cargo remove` as well~ `cargo remove` does not need fuzzy matching, because there is no unexpected behavior for the user - [x] ~Don't duplicate name permutation generation~ Unsure whether this is worth it - [ ] Shall we reject cases where multiple different permutations match? - [x] Add comments that explain the behavior
bors
added a commit
that referenced
this issue
Sep 4, 2024
Fix cargo add behaving different when translating package name Fixes #13702 Fixes #10680 TODOs - [x] ~Fuzzy match registry dependencies in `cargo remove` as well~ `cargo remove` does not need fuzzy matching, because there is no unexpected behavior for the user - [x] ~Don't duplicate name permutation generation~ Unsure whether this is worth it - [ ] Shall we reject cases where multiple different permutations match? - [x] Add comments that explain the behavior
dingxiangfei2009
pushed a commit
to dingxiangfei2009/cargo
that referenced
this issue
Sep 17, 2024
dingxiangfei2009
pushed a commit
to dingxiangfei2009/cargo
that referenced
this issue
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: bug
Command-add
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Problem
cargo add
behaves differently when operating on a package in a virtual workspace depending whether the package name is not translated or translated (cargo showswarning: translating …
).In the first case cargo adds a reference to dependency declared in
[workspace.dependencies]
- which I believe is the desired result.In the later case cargo adds the dependency and the version, but does not reference
[workspace.dependencies]
- I believe this is not desired.Steps
Reproduction script when adding
parking-lot
:Reproduction script when adding
parking_lot
:Possible Solution(s)
No response
Notes
I tested this with the latest rust release.
This might be related to this issue: #10680
Version
The text was updated successfully, but these errors were encountered: