-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support underline and shortline compatible for cargo-remove #14814
Comments
At least providing a "did you mean" more generally and not just for word separators) in the error messages would be good. However, I'm unsure how far we should take normalization in Cargo. Yes, we do it in |
If cargo-remove cannot translating underline and shortline, at least try giving a similar package name hint in the error message |
`cargo remove` already will suggest other tables if appropriate. `cargo add` auto-corrects `_` and `-`. This is an extension of the two by suggesting existing dependencies within the same table that are "close". I chose to make alt tables and alt deps mutually exclusive in the message because I didn't wantto deal with how to separate things if both show up. Most likely, people will only expect one or the other and if its in an alt table, then most likely they mean that. Related to rust-lang#14814
### What does this PR try to resolve? `cargo remove` already will suggest other tables if appropriate. `cargo add` auto-corrects `_` and `-`. This is an extension of the two by suggesting existing dependencies within the same table that are "close". Related to #14814 ### How should we test and review this PR? I chose to make alt tables and alt deps mutually exclusive in the message because I didn't wantto deal with how to separate things if both show up. Most likely, people will only expect one or the other and if its in an alt table, then most likely they mean that. ### Additional information
#14818 improved the error message. |
Thanks! |
Problem
Reproduction:
Proposed Solution
No response
Notes
No response
The text was updated successfully, but these errors were encountered: