Skip to content

Reuse timing metric collection logic between --timings and -Zbuild-analysis #16474

@weihanglo

Description

@weihanglo

Problem

cargo report timings is going to supercede the pre-existing cargo build --timings flag. The two parallel implementations that haven't yet fully shared the metric collection logic between them.

Possible solutions

We'd like to remove the old logic of how --timings collect metrics, and instead push relevent LogMessages t an in-memory queue, and after the build, we reuse code in cargo report timings to replay and generate the HTML report.

This is currently blocked on #16420.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-timingsArea: timingsC-cleanupCategory: cleanup within the codebaseS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewZ-build-analysisNightly: build-analysis

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions